Bluetooth: ISO: rm extra log statements in chan_send #97112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth ISO
Thalley
added
the
Trivial
cvinayak
requested changes
Oct 8, 2025
subsys/bluetooth/host/iso.c
Outdated
| iso_conn = chan->iso; | ||
|
|
||
| LOG_DBG("send-iso (ts)"); | ||
| BT_ISO_DATA_DBG("send-iso (ts)"); |
There was a problem hiding this comment.
There is already a BT_ISO_DATA_DBG above, may be append "%u us", ts there.
Suggested change
| BT_ISO_DATA_DBG("send-iso (ts)"); |
There was a problem hiding this comment.
Good catch. That's also the case in bt_iso_chan_send, so will probably just remove one of the 2 debug log statements
bt_iso_chan_send and bt_iso_chan_send_ts would log twice for each TX, which is unncessary. LOG_DBG statements include the function name by default, so the 2nd log statement was unncessary, and were removed. Added logging of the ts in bt_iso_chan_send_ts which would still make it possible to tell the 2 apart, even if CONFIG_LOG_FUNC_NAME_PREFIX_DBG=n. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
changed the title
|
cvinayak
approved these changes
Oct 8, 2025
kartben
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bt_iso_chan_send and bt_iso_chan_send_ts would log
twice for each TX, which is unncessary. LOG_DBG statements
include the function name by default, so the 2nd log
statement was unncessary, and were removed.
Added logging of the ts in bt_iso_chan_send_ts which
would still make it possible to tell the 2 apart,
even if CONFIG_LOG_FUNC_NAME_PREFIX_DBG=n.